Charges Bug

[Dr.Device]

I hate to point it out, given how many headaches charges have already caused you, but there is a bug in the way one charge clips are calculated, when combined with continuing or recoverable charges.

Basically, you're getting hit twice for the (+1/2) jump from 1 charges, when you should only be hit once.

Steps to reproduce:

Create a power (we'll use Succor).
Click Add modifiers, switch to limitations.
Select Charges
Check the box for continuing, leave it at the default 1 extra segment. The total value of the limitation should now be -1 1/2 (the value for 1 step down from 1 charge), which it is.
Check the box for 2 clips. The total value should now be -1 1/4 ( the value for 2 steps down the chart from 1 charge), but HD says it's -1.
Uncheck the box for continuing. The total value of the limitation should now be -1 1/2 (the value for 1 step down from 1 charge), which it is.
Check the box for Recoverable. The total value of the limitation should now be -1 (the value for 3 steps down from 1 charge), but HD says it's -3/4.


Continuing and Recoverable together, without Clips, gives you the correct result (-1 for 3 steps down the chart), so it seems that the problem is in Clips. Also, any base number of charges other than 1 yields the correct total as well.

[Simon]

HD's total is correct.

[Dr.Device]

I checked with Steve (http://www.herogames.com/forums/showthread.php?t=53728), and he agreed that I was calculating it correctly.

Is there something that he and I are both missing?

[archermoo]

Dan,

Looks like there is something to this. It appears as though instead of just figuring the first step down the charges ladder as being 1/2, it is figuring all steps as such. I was able to replicate the problem Dr. Device is talking about, using build 20070206061.

It is somewhat odd. From 1 charge, if I select Clips (listed as +1/2), Continuing changes from +1/2 to +1/4, as expected. However, when I select Continuing it reverts back to +1/2 and the total of the limitation becomes -1 instead of -1 1/4. It only seems to go dysfunctional when Clips are included though. If I select Recoverable (+3/4), Continuing changes to +1/4, and stays that way after it is selected.

Hope this helps.

[Simon]

I know what HD is doing -- it's doing what Steve had told me to do some time ago with respect to Clips on Charges.

I'll speak with him and determine if he wants the behavior to change or if Clips should continue to calculate the way it is.

[Dr.Device]

For what it's worth, the reason I noticed this is that, they way HD currently calculates, there is no difference in value between clips of 1 charge or clips of 2 charges if the charges are also continuous or recoverable. That doesn't seem right to me.

If you end up keeping it the way it is, would you mind explaining the logic of why HD calculates this the way it does? I'd appreciate it.

[Simon]

The "logic" is that it's the way Steve wanted it -- simple as that.

There is very little in the way of logic when Charges are involved. Extremely little.

Since Steve wants things calculated differently now, I've adjusted the way HD calculates the cost for 1 Charge when both Recoverable (or Continuing) and Clips are applied.